-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't reverse names in get_qualification #540
Don't reverse names in get_qualification #540
Conversation
@jakobandersen Could you confirm this is the correct thing to do? To me it looks good, but perhaps this is pointing at another bug elsewhere regarding some assumptions in the data received? |
Good find! However the suggested fix would break other cases. See the code comments. |
E.g. a function a::b::c::foo() is otherwise incorrectly displayed at c::b::a::foo()
898b405
to
0618acc
Compare
Thanks, I've updated the PR as you suggested |
Nice. I think the PR is ok for merging, and the fix is semantically correct, but I actually can't immediately construct an example right now that distinguishes it from the original PR. |
Just released v4.19.0 with the fix, all should be good now. |
E.g. a function
a::b::c::foo()
is otherwise incorrectly displayed atc::b::a::foo()
.Fixes #539.