Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx 3.5 compatibility #640

Merged
merged 2 commits into from
Feb 14, 2021
Merged

Sphinx 3.5 compatibility #640

merged 2 commits into from
Feb 14, 2021

Conversation

utzig
Copy link
Contributor

@utzig utzig commented Feb 14, 2021

  • Allow working with newer Sphinx 3.5.0
  • Add Sphinx 3.5.0 and change 3.4.x branch to 3.5.x in unit tests matrix. This should fix the broken CI.

This should fix the failures seen on #638 and #639

Signed-off-by: Fabio Utzig <utzig@apache.org>
Add Sphinx 3.5.0 and change 3.4.x branch to 3.5.x. This should fix the
broken CI.

Signed-off-by: Fabio Utzig <utzig@apache.org>
@utzig
Copy link
Contributor Author

utzig commented Feb 14, 2021

@vermeeren TBH I have not tested with Sphinx 3.5.0, haven't even seen it came out before just now. But I don't see a reason for it not working, and even if it has failures, it will need to be fixed anyway, so this should be fine.

@vermeeren
Copy link
Collaborator

@jakobandersen Any changes that you know of on the Sphinx side that need some adaptation over here? Seems fine to me as the CI is working nicely.

@jakobandersen
Copy link
Collaborator

No, I think it should work fine.
Though, if I understand correctly, the next major/minor release is going to be v4 (https://github.com/sphinx-doc/sphinx/milestone/74), but the suggested version constraint of course works as well. For that Sphinx release I suggest constraining only on the major versions, unless something unexpected comes up. Then it's only every year it needs a quick bump :-).

@vermeeren
Copy link
Collaborator

@jakobandersen Will do, thanks for the quick reply.

@vermeeren vermeeren self-requested a review February 14, 2021 21:06
@vermeeren vermeeren self-assigned this Feb 14, 2021
@vermeeren vermeeren added the packaging Requirements, setup.py, etc label Feb 14, 2021
michaeljones pushed a commit that referenced this pull request Feb 14, 2021
@michaeljones michaeljones merged commit 2514a90 into breathe-doc:master Feb 14, 2021
@utzig utzig deleted the sphinx-3.5 branch February 14, 2021 21:17
@jmckenna
Copy link

As this issue prevents those using Sphinx 3.5.0 + breathe, I'm kindly wondering when the next breathe release will be?

@jmckenna
Copy link

PS. Sphinx 3.5.1 was released moments ago...

@vermeeren
Copy link
Collaborator

@jmckenna I intended to release after the current 2 PRs had been merged, but I agree the compatibility update is needed earlier. Just released v4.27.0 containing this fix.

@jmckenna
Copy link

thanks @vermeeren ! I appreciate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Requirements, setup.py, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants