You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This would open the door to migrating away from clj-http, and instead rely on the native HttpClient (e.g. via hato which is a great little library).
Moreover, even if you don't like the sounds of that, the current http namespace could really use some love.
First of all, I am kind of confused by the use of many dynamic vars (are these intended to be re-bound often?), and a bunch of alter-var-root calls under connect!. I am probably missing something, but I 'm having trouble understanding the motivation behind this kind of pattern. From what I saw in various examples/tests etc, usages of connect! could easily be served by an atom instead. Anyway, it's just something that caught my eye...
Secondly, the way clj-http is used, it creates a brand new HttpClient for every single outbound request (some functions do two requests, so that would be 2 HttpClient objects). This is kind of wasteful, and if fact the clj-http docs do draw attention to that.
Anyway, I'm just probing here...let me know of your thoughts 👍
The text was updated successfully, but these errors were encountered:
This would open the door to migrating away from
clj-http
, and instead rely on the nativeHttpClient
(e.g. via hato which is a great little library).Moreover, even if you don't like the sounds of that, the current
http
namespace could really use some love.First of all, I am kind of confused by the use of many dynamic vars (are these intended to be re-bound often?), and a bunch of
alter-var-root
calls underconnect!
. I am probably missing something, but I 'm having trouble understanding the motivation behind this kind of pattern. From what I saw in various examples/tests etc, usages ofconnect!
could easily be served by an atom instead. Anyway, it's just something that caught my eye...Secondly, the way
clj-http
is used, it creates a brand newHttpClient
for every single outbound request (some functions do two requests, so that would be 2HttpClient
objects). This is kind of wasteful, and if fact the clj-http docs do draw attention to that.Anyway, I'm just probing here...let me know of your thoughts 👍
The text was updated successfully, but these errors were encountered: