Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature | allow to add jenkinsClassnamePrefix #138

Conversation

prnsml
Copy link
Contributor

@prnsml prnsml commented Oct 9, 2020

Hi, please allow to set prefixes in Jenkins

this PR is similar to #94 , but it doesn't require to explicitly add '.' to the end of jenkinsClassnamePrefix

@clayreimann
Copy link
Collaborator

Hi @prnsml, sorry it took so long to get to this. This looks good, but would you be willing to add a test to prevent regressions? @przemuh would this work for you too?

@prnsml
Copy link
Contributor Author

prnsml commented Oct 27, 2020

Hi, I will try to find some time to add tests this weekend. Thanks!

@prnsml
Copy link
Contributor Author

prnsml commented Oct 31, 2020

Added simple test.

@przemuh
Copy link

przemuh commented Nov 1, 2020

Looks good :)

@nils-hoyer
Copy link

nils-hoyer commented Jan 12, 2021

since all checks passend and no questions left can you please merge this feature

@jannisbecker
Copy link

Please consider merging this, I also stumbled upon this issue.

@taichikuji
Copy link

Agree. Can you merge it so that the issue gets fixed?

@mikolajadamski
Copy link

Hello, could you merge this solution please? :) It would really help with jenkins integration

@omega
Copy link

omega commented Sep 27, 2022

@prnsml is it possible to get a new release of this pull request, but rebased on the other latest changes to the "official" junit reporter?

@clayreimann clayreimann merged commit e77a5d8 into michaelleeallen:master Sep 27, 2022
@clayreimann
Copy link
Collaborator

@omega This PR is now in v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants