Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProxyWatchers small declaration issue #69

Open
zeroinformatique opened this issue May 7, 2020 · 0 comments
Open

ProxyWatchers small declaration issue #69

zeroinformatique opened this issue May 7, 2020 · 0 comments

Comments

@zeroinformatique
Copy link

zeroinformatique commented May 7, 2020

Hello, thanks for this library, it's very useful !

I use the ProxyWatchers in my code, but since I create the proxies only once and use an interface to access them, I had to fetch the type manually with:

import { extractVuexModule, createProxy } from "vuex-class-component";
import { ProxyWatchers } from "vuex-class-component/dist/interfaces";

Hitting "/dist/interfaces" doesn't really pleases me. Could you move it to the root declaration?

Also I noticed that in SubScribeActionCallback, "before" and "after" functions are both mandatory, they should be optional (either before, after, or before + after)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant