Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nfc-felica-lib to project proper #255

Merged
merged 2 commits into from
Dec 16, 2018

Conversation

phcoder
Copy link
Collaborator

@phcoder phcoder commented Nov 21, 2018

nfc-felica-lib is treated pretty much like part of the project, so put it in project proper.

Felica lite has following quirks:

* No system code list
* At least some variants respond to any system code
* Attempting to read above 0x20 results in disconnected tag

While on it, fix to keep already read data in case of disconnect
nfc-felica-lib is treated pretty much like part of the project, so put it in
project proper.
@micolous
Copy link
Collaborator

Sounds good, I'm going to merge this.

Sorry, I missed your pull requests on upstream -- maybe now this will be easier to fix up in Metrodroid proper. I'm not aware of others who are using that anyway, so I will archive that repository.

micolous added a commit to metrodroid/nfc-felica-lib that referenced this pull request Dec 16, 2018
@micolous micolous merged commit 232fa1c into metrodroid:master Dec 16, 2018
@micolous micolous added this to the 2.9.37 milestone Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants