Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of idedata #44

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

bjsowa
Copy link
Contributor

@bjsowa bjsowa commented Jul 25, 2022

Fixes #32 .
I wrote this PR only to demonstrate the problem, not to provide the best solution.
AFAIK, running pio init --ide <ide name> runs the idedata target to generate idedata.json file which contains information about include paths, defines etc. which is used to generate IDE-specific configuration files.
Currently the extra_script.py completely ignores the idedata target. This was done to avoid building the library when IDE fetches project metadata.
I think the script should instead update some of the environments (probably the global_env and projenv) regardless of the target name.

@bjsowa
Copy link
Contributor Author

bjsowa commented Jul 26, 2022

@pablogs9 @Acuadros95 Could you look at that?

@Acuadros95 Acuadros95 self-assigned this Jul 26, 2022
@Acuadros95 Acuadros95 marked this pull request as ready for review July 28, 2022 14:30
@Acuadros95
Copy link
Contributor

Acuadros95 commented Jul 28, 2022

Currently the extra_script.py completely ignores the idedata target. This was done to avoid building the library when IDE fetches project metadata.
I think the script should instead update some of the environments (probably the global_env and projenv) regardless of the target name.

Agree, I have tested it and your fix looks OK.

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intellisense in VS Code not working with micro_ros_platformio
3 participants