Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

condition_variable::wait() should take std::unique_lock as an argument #67

Open
LnnrtS opened this issue Jan 13, 2021 · 1 comment
Open

condition_variable::wait() should take std::unique_lock as an argument #67

LnnrtS opened this issue Jan 13, 2021 · 1 comment
Assignees
@ilg-ul
Labels
enhancement

Comments

@LnnrtS
Copy link
Contributor

LnnrtS commented Jan 13, 2021

This way it is assured that the mutex has been locked previously and it is harder to use this function the wrong way.

Maybe the whole interface could be changed to match std::condition_variable but I haven't checked more details.
@ilg-ul
Copy link
Contributor

ilg-ul commented Jan 13, 2021

When it was designed, the intent was to match the standard specs, either I missed something, or the specs were improved.

We have to check all definitions and make them match the current standard.

@ilg-ul ilg-ul self-assigned this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilg-ul ilg-ul

Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilg-ul @LnnrtS