-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't fail if a dependency is not loaded #1
Comments
This is actually really posing a problem. If you specify a dependency and it doesn't exist, your callback is never called and you don't know what one is missing. If you have lots of components it makes it really hard to track down. |
Hmm, it just uses async.auto under the hood, so its quite possible that its a problem with that |
The This is a pretty fundamental issue with |
Thought I may have been stung by this problem, so I wrote the following to test:
Just putting here so it doesn't get lost. Will integrate into the module and release a new version when I can |
Circular dependencies also cause a problem. This may be a bug with the code but it becomes very hard to track this down when
|
Olly just fell foul of this issue too. There must be something can can be done in component-loader to make this throw a decent error if there is a cyclic dependancy graph or a missing dependancy. |
Both situations now throw an error in v0.1.0 |
Example below. I would expect an error to be passed as the first argument where I am doing a
console.log()
. Not only does it not get an error, but it looks like the callback is not called at all and this program just terminates.The text was updated successfully, but these errors were encountered: