Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ioredis v5 support #22

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

ozonep
Copy link

@ozonep ozonep commented May 8, 2024

Fixes #20

Main changes:

  1. Updated ioredis dependency to v5
  2. Fixed types to work with ioredis v5
  3. Replaced bluebird with setTimeout
  4. Updated Readme to mention ioredis v5
  5. Updated comments that were wrong

P.S. I'm not a pnpm user, so after installing latest pnpm and updating ioredis to v5, pnpm simply decided to ignore pnpm-lock file (due to old lock file version) and updated all the deps together with ioredis... :-/ I hope that's fine.

@ozonep
Copy link
Author

ozonep commented May 15, 2024

@AVVS Since this would require a major version bump, I can also open a PR to replace uuid with Node's randomUUID to make this package dependency-free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ioredis v5 is not supported yet
1 participant