Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch img alt parsing to on by default #182

Closed
snarfed opened this issue Apr 29, 2023 · 5 comments
Closed

Switch img alt parsing to on by default #182

snarfed opened this issue Apr 29, 2023 · 5 comments

Comments

@snarfed
Copy link
Member

snarfed commented Apr 29, 2023

It's been over 3 yrs since this was officially incorporated into the spec, 4-5 yrs since #83 and kartikprabhu#56. img alt parsing is pretty standard and expected now, and it trips people up when they don't know they need to turn it on with img_with_alt=True. It's probably time to drop the feature flag, or at least switch it to on by default!

cc @ludovicchabant

@gRegorLove
Copy link
Member

Agreed. img-alt parsing has been live in php-mf2 since 2022-02-09.

@capjamesg
Copy link
Member

I have filed a PR to implement this (PR #184). @snarfed I have tagged you as a reviewer.

@sknebel
Copy link
Member

sknebel commented Jun 28, 2023

For context, this has gotten "stuck" because it's a breaking change and there were more things on the list before doing a major version change before this all fell asleep. I'd propose to do the change Python3 only and then make a major version jump.

@capjamesg
Copy link
Member

I agree. Python 2.7 and 3.6 deprecation, and the corresponding test suite environment fixes, is at the top of the TODO list.

@capjamesg
Copy link
Member

The PR implementing this (#184) has been merged and will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants