Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better types #79

Closed
Kikobeats opened this issue Oct 13, 2021 · 4 comments · Fixed by #132
Closed

Better types #79

Kikobeats opened this issue Oct 13, 2021 · 4 comments · Fixed by #132
Labels
enhancement New feature or request

Comments

@Kikobeats
Copy link
Member

There are some TODO's to improve types detection based on the context environment

@Kikobeats Kikobeats added the enhancement New feature or request label Oct 13, 2021
@goleary
Copy link
Contributor

goleary commented Nov 23, 2021

additionally, the function prop is missing from the opts type.

@goleary
Copy link
Contributor

goleary commented Nov 23, 2021

The types that were added actually broke our environment due to how we use mql (which was typeless before)

image

@goleary
Copy link
Contributor

goleary commented Nov 23, 2021

The media return types are also incorrect

image

Just realized that I have types I've been using internally that probably should've been contributed back to this project

https://gist.github.com/goleary/d2a99c345695db21d9f1f27524f47c40

@goleary
Copy link
Contributor

goleary commented Nov 23, 2021

went ahead and created #81 by combining what's here with the types I've been maintaining on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants