Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adding semver ranges to the packages in the list #2

Closed
mischah opened this issue Sep 28, 2018 · 2 comments
Closed

Feature: Adding semver ranges to the packages in the list #2

mischah opened this issue Sep 28, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@mischah
Copy link
Member

mischah commented Sep 28, 2018

This would make it possible to define certain versions or version ranges as allowed/disallowed.

Specifying the version range should be optional.

Example list:

[
  "react",
  "react-dom@^2.2.1",
  "redux@>=1.0.0-rc.0 <1.0.1",
  "react-redux@^2 <2.2 || > 2.3"
]

I’m not sure about the combination between package name and semver range via the @? Any better ideas?

I think something like this is easier than having to use an array of object, right?

[
  {
    package: "react",
    versions: ""
  },
  {
    package: "react-dom",
    versions: ">2.1"
  }
]
@mischah mischah added the enhancement New feature or request label Sep 28, 2018
@chrkhl
Copy link
Collaborator

chrkhl commented Oct 2, 2018

I already had this feature in mind and would prefer the first option (array of strings).

@chrkhl
Copy link
Collaborator

chrkhl commented Oct 19, 2018

I opened pull request #4 for this feature.

@mischah: Would be nice if you could throw an eye 👁️ on this 😉

@chrkhl chrkhl closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants