Run eslint during pretest, fix existing eslint findings

micromatch · Sep 17, 2019 · 0682367 · 0682367
1 parent 5ecda3a
commit 0682367
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 14 deletions.
diff --git a/bench/glob-parent.js b/bench/glob-parent.js
@@ -1,7 +1,7 @@
 'use strict';
 
 const { Suite } = require('benchmark');
-const { cyan, red, green } = require('ansi-colors');
+const { red } = require('ansi-colors');
 const argv = require('minimist')(process.argv.slice(2));
 const parent = require('glob-parent');
 const scan = require('../lib/scan');
@@ -11,7 +11,7 @@ const scan = require('../lib/scan');
  */
 
 const cycle = (e, newline) => {
-  process.stdout.write(`\u001b[G  ${e.target}${newline ? `\n` : ''}`);
+  process.stdout.write(`\u001b[G  ${e.target}${newline ? '\n' : ''}`);
 };
 
 function bench(name, options) {

diff --git a/bench/index.js b/bench/index.js
@@ -1,7 +1,7 @@
 'use strict';
 
 const { Suite } = require('benchmark');
-const { cyan, red, green } = require('ansi-colors');
+const { red } = require('ansi-colors');
 const argv = require('minimist')(process.argv.slice(2));
 const mm = require('../node_modules/minimatch');
 const pm = require('..');
@@ -11,7 +11,7 @@ const pm = require('..');
  */
 
 const cycle = (e, newline) => {
-  process.stdout.write(`\u001b[G  ${e.target}${newline ? `\n` : ''}`);
+  process.stdout.write(`\u001b[G  ${e.target}${newline ? '\n' : ''}`);
 };
 
 const bench = (name, options) => {

diff --git a/examples/extglob.js b/examples/extglob.js
@@ -1,6 +1,5 @@
 const pm = require('..');
 
-
 console.log(pm.makeRe('(a|b|c)'));
 console.log(pm.makeRe('!(a|b|c)'));
 console.log(pm.makeRe('*(a|b|c)'));

diff --git a/examples/match.js b/examples/match.js
@@ -1,7 +1,7 @@
 'use strict';
 
 const path = require('path');
-const assert = require('assert');
+// const assert = require('assert');
 const pm = require('..');
 
 /**

diff --git a/examples/option-expandRange.js b/examples/option-expandRange.js
@@ -11,9 +11,9 @@ const regex = pm.makeRe('foo/{01..25}/bar', {
 console.log(regex);
 //=> /^(?:foo\/((?:0[1-9]|1[0-9]|2[0-5]))\/bar)$/
 
-console.log(regex.test('foo/00/bar')) // false
-console.log(regex.test('foo/01/bar')) // true
-console.log(regex.test('foo/10/bar')) // true
-console.log(regex.test('foo/22/bar')) // true
-console.log(regex.test('foo/25/bar')) // true
-console.log(regex.test('foo/26/bar')) // false
+console.log(regex.test('foo/00/bar')); // false
+console.log(regex.test('foo/01/bar')); // true
+console.log(regex.test('foo/10/bar')); // true
+console.log(regex.test('foo/22/bar')); // true
+console.log(regex.test('foo/25/bar')); // true
+console.log(regex.test('foo/26/bar')); // false
diff --git a/lib/utils.js b/lib/utils.js
@@ -16,7 +16,7 @@ exports.removeBackslashes = str => {
   return str.replace(REGEX_REMOVE_BACKSLASH, match => {
     return match === '\\' ? '' : match;
   });
-}
+};
 
 exports.supportsLookbehinds = () => {
   const segs = process.version.slice(1).split('.');

diff --git a/package.json b/package.json
@@ -18,10 +18,12 @@
     "node": ">=8"
   },
   "scripts": {
+    "pretest": "eslint .",
     "test": "mocha",
     "cover": "nyc --reporter=text --reporter=html mocha"
   },
   "devDependencies": {
+    "eslint": "^6.4.0",
     "fill-range": "^7.0.1",
     "gulp-format-md": "^2.0.0",
     "mocha": "^6.0.2",

diff --git a/test/globstars.js b/test/globstars.js
@@ -3,7 +3,7 @@
 require('mocha');
 const assert = require('assert').strict;
 const match = require('./support/match');
-const { isMatch, makeRe } = require('..');
+const { isMatch } = require('..');
 
 describe('stars', () => {
   describe('issue related', () => {