Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixing different versions and flavours of apache HTTP client metrics does not work with prometheus. #3802

Closed
flozano opened this issue May 2, 2023 · 1 comment
Closed

Mixing different versions and flavours of apache HTTP client metrics does not work with prometheus. #3802

flozano opened this issue May 2, 2023 · 1 comment
Labels
invalid An issue that we don't feel is valid

Comments

@flozano
Copy link

flozano commented May 2, 2023 •
edited
Loading

Because of #877, and given that MicrometerHttpClientInterceptor and MicrometerHttpRequestExecutor are not exactly using the same set of tags, if you use MicrometerHttpRequestExecutor you cannot see your MicrometerHttpClientInterceptor metrics in prometheus.

It would be nice to have the same set of tags in both. One can try to workaround it (eg: add "outcome" to extra tags in MicrometerHttpClientInterceptor), but it is far from ideal that they don't work out of the box together.
@flozano flozano changed the title Mixing sync and async apache HTTP client metrics does not work with prometheus. Mixing different versions and flavours of apache HTTP client metrics does not work with prometheus. May 2, 2023
@flozano
Copy link
Author

flozano commented May 2, 2023

I mixed code from two different versions of micrometer. Didn't notice before opening the issue.

@flozano flozano closed this as completed May 2, 2023
@jonatan-ivanov jonatan-ivanov added invalid An issue that we don't feel is valid and removed waiting-for-triage labels May 2, 2023
@jonatan-ivanov jonatan-ivanov closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid An issue that we don't feel is valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flozano @jonatan-ivanov