Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Elastic APM #793

Closed
cah-andrew-fitzgerald opened this issue Aug 17, 2018 · 10 comments
Closed

Support Elastic APM #793

cah-andrew-fitzgerald opened this issue Aug 17, 2018 · 10 comments

Comments

@cah-andrew-fitzgerald
Copy link

Elastic (Elasticsearch/Kibana) is working on a new APM solution.
It would be nice if it worked out of the box with micrometer.

see elastic/apm-agent-java#112

@jkschneider jkschneider added this to the 1.1.0-rc.1 milestone Sep 27, 2018
@jkschneider
Copy link
Contributor

Currently no spec has been produced by Elastic, so pushing this to 1.2.0.

@jkschneider jkschneider modified the milestones: 1.1.0-rc.1, 1.2.0 Oct 14, 2018
@jkschneider jkschneider modified the milestones: 1.2.0, 1.x Oct 26, 2018
@felixbarny
Copy link
Contributor

felixbarny commented Nov 29, 2018

A spec of the API is here: https://www.elastic.co/guide/en/apm/server/current/metricset-api.html and here: https://github.com/elastic/apm-server/blob/master/docs/spec/metricsets/metricset.json

Note that it currently only supports counters and gauges.

@jkschneider
Copy link
Contributor

Thanks @felixbarny. Counters and gauges are good enough. Timers are just composed of a series of counters and gauges. We can make it work.

@felixbarny
Copy link
Contributor

See also my very rough WIP for the agent-internal metric tracking here: elastic/apm-agent-java#360

@sabareeshkkanan
Copy link

This will be a great future. When can we expect this

@surenraju-zz
Copy link

This feature will be very useful.

@felixbarny
Copy link
Contributor

We're also thinking about automatically adding a micrometer Collector via the Elastic APM Java agent which reports to the APM Server if the agent is attached - so that no code changes are necessary.

See also elastic/apm-agent-java#893

@ngotzmann
Copy link

Hello,
are there any news on this feature?

@xeraa
Copy link

xeraa commented Dec 25, 2020

The APM agent has a Micrometer integration in beta now: https://www.elastic.co/guide/en/apm/agent/java/current/metrics.html#metrics-micrometer

@shakuzen
Copy link
Member

It sounds like deferring to the Micrometer support in the agent is a good resolution to this request. We can add some documentation to https://micrometer.io/docs/registry/elastic referring to the APM docs. I have made micrometer-metrics/micrometer-docs#203 for that.

@shakuzen shakuzen removed this from the 1.x milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants