Improve warning about Gauge re-registration in the docs #5617
Conversation
|
Since it is on the hot-path, I'm not 100% sure about the warning but I think we should have the tests and document it. |
There was a problem hiding this comment.
Since it is on the hot-path, I'm not 100% sure about the warning but I think we should have the tests and document it.
I like the warning because it makes it easier to see that information is being ignored. I only noticed information was being lost because I tested it in a system where I know what the gauges data should be. When meters are silently dropping data and its not know what the data should be, someone will take the data they see and not even know they are not seeing some of the data that was registered with the system.
We should see how much it costs with JMH benchmarks. I don't know if we already have a good benchmark that would measure the difference. |
|
@jonatan-ivanov do you want to separate out the documentation changes from the code changes so we can get the documentation changes into the release and work on benchmarking the code changes? |
jonatan-ivanov
changed the title
Closes #5616