Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shaded netty to 4.1.115.Final in micrometer-registry-statsd to address CVE-2024-47535 #5660

Conversation

rkuijt-mollie
Copy link

Mitigates GHSA-xq3w-v528-46rv in Netty dependency.

@pivotal-cla
Copy link

@rkuijt-mollie Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@rkuijt-mollie
Copy link
Author

Not signing the CLA as this change is minor enough.

@jonatan-ivanov
Copy link
Member

We have automation around this, this will be upgraded automatically before the next release.
Could you please tell us through which dependency did you bump into this?

@krishnatippur
Copy link

I am running into a vulnerability check failure w.r.t. CVE-2024-47535 when pulling in micrometer-registry-statsd dependency.

@jonatan-ivanov , you mentioned this will be upgraded automatically before the next release - what is the ETA for the next release?

@jonatan-ivanov
Copy link
Member

It is scheduled for December 9th, see the calendar: https://spring.io/projects#release-calendar
Does that work for you?

@krishnatippur
Copy link

Thanks for that link. I would like this to be done sooner, since https://access.redhat.com/security/cve/cve-2024-47535 is a medium severity vulnerability. Otherwise until December 9th, our internal vulnerability scanners will need to be updated for exceptions per asset, and we have several hundreds of them :(

Perhaps a patch/minor release in the meantime? Would that be possible?

@shakuzen shakuzen changed the title Bump io.netty:netty-bom from 4.1.114.Final to 4.1.115.Final Bump io.netty:netty-bom to 4.1.115.Final Nov 15, 2024
@shakuzen
Copy link
Member

I would like this to be done sooner, since https://access.redhat.com/security/cve/cve-2024-47535 is a medium severity vulnerability.

In case it isn't clear to anyone, if you are not running your production apps on Windows, this CVE is a false positive for you (even if you are running Windows in production, an attacker needs to be able to create a file on the system where the app is running). Vulnerability scanners should be more sophisticated and organizations need processes in place to consider such context. This is creating more work for everyone to solve a problem that doesn't exist for a vast majority of users.

We can do an earlier release, but I don't think it's a reasonable expectation that we do so for false positive CVEs. We get reports like this with some frequency and they're consistently false positives. We can do a release in this case because we may have some users running on Windows in production, but I expect that is a vanishingly small number of our users.

@shakuzen shakuzen added this to the 1.12.13 milestone Nov 15, 2024
@shakuzen shakuzen added type: task A general task registry: statsd A StatsD Registry related issue labels Nov 15, 2024
@krishnatippur
Copy link

I would like this to be done sooner, since https://access.redhat.com/security/cve/cve-2024-47535 is a medium severity vulnerability.

In case it isn't clear to anyone, if you are not running your production apps on Windows, this CVE is a false positive for you (even if you are running Windows in production, an attacker needs to be able to create a file on the system where the app is running). Vulnerability scanners should be more sophisticated and organizations need processes in place to consider such context. This is creating more work for everyone to solve a problem that doesn't exist for a vast majority of users.

We can do an earlier release, but I don't think it's a reasonable expectation that we do so for false positive CVEs. We get reports like this with some frequency and they're consistently false positives. We can do a release in this case because we may have some users running on Windows in production, but I expect that is a vanishingly small number of our users.

I agree that our org's vulnerability scanners can/should be smarter. False positives like this derail us all, so I appreciate you taking this up off-cycle. Thank you!

@shakuzen shakuzen closed this in edd12f2 Nov 15, 2024
@shakuzen shakuzen changed the title Bump io.netty:netty-bom to 4.1.115.Final Bump shaded netty to 4.1.115.Final in micrometer-registry-statsd to address CVE-2024-47535 Nov 15, 2024
@shakuzen
Copy link
Member

Micrometer 1.12.13, 1.13.8, and 1.14.1 with this upgrade have been released and should be available from Maven Central shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
registry: statsd A StatsD Registry related issue type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants