Replies: 2 comments 1 reply
-
@altro3 Please note that we appreciate your contributions a lot. Could you please ask me as a reviewer in your PRs? I will try to be on top of them and do not make you wait. |
Beta Was this translation helpful? Give feedback.
0 replies
-
@sdelamo Yes, I understand that the last merges were not according to the protocol. But there were fairly minor fixes, I would say, routine ones. It seemed to me that I could do this without review, because... As you correctly noted, the review can take several weeks. Okay, I'll add you to merge requests. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We merged the following PRs:
without a Review.
we should accept PRs which change production code without a review from someone.
We do exceptions. for example: If you write a PR which improves a test or updates a dependency version, it can be merged without a review. But a PR changing production code should be reviewed by someone.
Beta Was this translation helpful? Give feedback.
All reactions