[Bug]: Custom Deploy.ps1 is not used

[StefanMaron]

AL-Go version

5.2

Describe the issue

I want to use the buildModes to deploy a different version to sandboxes than to AppSource, for licensing purposes.
The only way I found to achieve this is to create a modified deploy.ps1 script like described here:

AL-Go/Scenarios/settings.md

Line 261 in 12f2a56

> You can create one script to override all deployment functionality, by creating a script called Deploy.ps1 in the .github folder.

I did change those two parts:

but still logs the default message and used the main apps:

Is there anything I am missing or I can check to resolve this?

Expected behavior

Custom Deploy.ps1 should be used if put into .github folder

Steps to reproduce

create a custom Deploy.ps1 file, check the log output

Additional context (logs, screenshots, etc.)

No response

[freddydk]

Not sure buildModes should be used for this, @mazhelez do you know?

On the actual question - this is an error in the documentation - we support DeployTo<environmentType>.ps1 - we don't actually support a complete override of all.

Will fix the documentation.

[mazhelez]

In some cases, it does make sense to deploy the artifacts from the non-default build mode, as in this particular scenario.

Deploy action, however, seems to be wired to use the -Apps artifacts (from the default build mode).

AL-Go/Actions/Deploy/Deploy.ps1

Line 46 in 12f2a56

$projectApps = @((Get-ChildItem -Path $artifactsFolder -Filter "$project-$refname-Apps-*.*.*.*") | ForEach-Object { $_.FullName })

However, in your custom script you can still query for other artifacts (the way you already do), so I believe if you fix your Deploy.ps1 to be .github/DeployTo<environmentType>.ps1, then it should work.

[StefanMaron]

@mazhelez
After I changed the name to DeployToSandbox.ps1 and added "EnvironmentType": "Sandbox", to my deploy configuration, it seems to pick up the script now.

But why does this have to be so complicated? Now its failing because it expect a different parameter configuration than the original Deploy.ps1

@freddydk
If the BuildModes are not meant to be used in deployment or submission to appsource, what is the usecase of them?

[freddydk]

I think buildModes was introduced for something different, but it might make sense to add a field "buildMode" to the DeployTo<env> setting, this would greatly simplify this scenario I guess and make the buildModes more useful.

[StefanMaron]

@freddydk This would solve this issue for me 100%

[freddydk]

Shipped in preview
DeployTo structure now includes a buildMode setting