-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Custom Deploy.ps1 is not used #1143
Comments
Not sure buildModes should be used for this, @mazhelez do you know? On the actual question - this is an error in the documentation - we support Will fix the documentation. |
In some cases, it does make sense to deploy the artifacts from the non-default build mode, as in this particular scenario. Deploy action, however, seems to be wired to use the AL-Go/Actions/Deploy/Deploy.ps1 Line 46 in 12f2a56
However, in your custom script you can still query for other artifacts (the way you already do), so I believe if you fix your Deploy.ps1 to be |
@mazhelez But why does this have to be so complicated? Now its failing because it expect a different parameter configuration than the original @freddydk |
I think buildModes was introduced for something different, but it might make sense to add a field "buildMode" to the |
@freddydk This would solve this issue for me 100% |
Shipped in preview |
AL-Go version
5.2
Describe the issue
I want to use the
buildModes
to deploy a different version to sandboxes than to AppSource, for licensing purposes.The only way I found to achieve this is to create a modified deploy.ps1 script like described here:
AL-Go/Scenarios/settings.md
Line 261 in 12f2a56
I did change those two parts:
![image](https://private-user-images.githubusercontent.com/24838311/348690524-39223b63-5772-4f06-9e2e-d1ce63a1ab56.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyNjc4NTcsIm5iZiI6MTcyNDI2NzU1NywicGF0aCI6Ii8yNDgzODMxMS8zNDg2OTA1MjQtMzkyMjNiNjMtNTc3Mi00ZjA2LTllMmUtZDFjZTYzYTFhYjU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIxVDE5MTIzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEwMDU3ODJkYWVjMGZlOWY0YzQ3ODhjZjY5MGVjMWUzNGU5YjhlOTc4YWU4OWM0M2M3OGYxNDliZGQyODA3NGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.hDTslIvj3ByxBaQwq94beYwnh__1gVH-6Q-8czPRhi8)
but still logs the default message and used the main apps:
![image](https://private-user-images.githubusercontent.com/24838311/348690638-6fe84242-58b8-4b90-9a90-f45717b52cdd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyNjc4NTcsIm5iZiI6MTcyNDI2NzU1NywicGF0aCI6Ii8yNDgzODMxMS8zNDg2OTA2MzgtNmZlODQyNDItNThiOC00YjkwLTlhOTAtZjQ1NzE3YjUyY2RkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIxVDE5MTIzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI5YmY1MTVlMTU1YmMxZmI5YWIzNmZjMjMzMTAwMmM2NTJmMTc0ZTJhNmQ0Njc3MzBiNTE1OTU5MDlhZWZkZmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.iy9j5TMH4e-z3S84a4heNbDXYZy_ITna1MFsaTznDXU)
Is there anything I am missing or I can check to resolve this?
Expected behavior
Custom Deploy.ps1 should be used if put into .github folder
Steps to reproduce
create a custom Deploy.ps1 file, check the log output
Additional context (logs, screenshots, etc.)
No response
The text was updated successfully, but these errors were encountered: