Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repoVersion always updated + added in Increment Version Number workflow #985

Open
dsaveyn opened this issue Mar 15, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@dsaveyn
Copy link

dsaveyn commented Mar 15, 2024

We have a multi project repository which has the following state:

repoVersion = 23.0

  • App 1:
    • app.json ==> 23.0
  • App 2:
    • app.json ==> 23.0
  • App 3:
    • app.json ==> 23.0

The repoVersion property is not configured on project level, only on repo level.

We want to update the repoVersion only when there's a new major release.

Suppose we need to release a new feature in App 3 which relies on a change in App 1, we would like to update only the version numbers of those apps affected by the change.

So for example, our desired result would be:

  • App 1:
    • app.json ==> 23.1
  • App 2:
    • app.json ==> 23.0 (no changes done)
  • App 2:
    • app.json ==> 23.1

But, when we use the Increment Version Number workflow, to achieve the above scenario, the following happens:

repoVersion = 23.0

  • App 1:

    • repoVersion (new): 23.1
    • app.json ==> 23.1
  • App 3:

    • repoVersion (new): 23.1
    • app.json ==> 23.1

So the repoVersion is added to the affected projects, something we don't want since it was already configured on repo level.

Also, any chance we could get a parameter to define if we want to update the repoVersion or not?

@dsaveyn dsaveyn closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@dsaveyn dsaveyn reopened this Mar 15, 2024
@freddydk
Copy link
Collaborator

The RepoVersion is actually a project version and it covers all apps in a specific project.
But, we will discuss whether we can make this better.

@freddydk freddydk added the enhancement New feature or request label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants