-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule AA0234 implemented inconsistently? #7787
Comments
Hi @NKarolak, Thanks for the issue. |
This also applies to rule AA0247. It is actually an info, but in reality it's disabled. |
@thpeder Any news on this? |
I've just found out that AA0234 also fires on missing table field tooltips even if a table object or table field are
Could you please fix that as well? |
Hi @NKarolak, We have aligned the rule with the other similar ones (that is DefaultSeverity=Info and IsEnabledByDefault=false). Please note that we distinguish between a rule being disabled or having its default severity set to Hidden. This distinction can be influenced by several factors, such as performance considerations (since Hidden diagnostics are computed while disabled ones are not) or the diagnostic serving as an entry point for a code action (as Hidden diagnostics still show up on hover). Please open a new case for the AA0234 problem and any further issues that you encounter. Thank you! |
The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 26.0.23829.0 and VS Code Extension Version 15.0.1128421. If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo For more details on code branches and docker images please read: |
Please include the following with each issue:
1. Describe the bug
Rule AA0234 is not activated the way we know it from other rules, inconsistently. Bug or feature for all new rules to come?
2. To Reproduce
By default, rule AA0234 is set to action Warning, as we can see in the docs, and in the AZ AL DevTools Code Analyzers view:
This usually means, that this rule is active. But it isn't. Steps to reproduce the behavior:
I know that this is by design as per docs:
But when you instruct to "enable the rule", I'd assume to find it first in disabled state - not in state "Warning", but for some weird reasons not working :-/
3. Expected behavior
The rule should be simply action = Hidden by default.
4. Actual behavior
The rule is Warning by default, but is in fact not active until we add it to a ruleset. I don't understand why it was solved that way.
5. Versions:
Internal work item: AB#540883
The text was updated successfully, but these errors were encountered: