Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule AA0234 implemented inconsistently? #7787

Closed
NKarolak opened this issue Jul 4, 2024 · 6 comments
Closed

Rule AA0234 implemented inconsistently? #7787

NKarolak opened this issue Jul 4, 2024 · 6 comments
Labels
accepted CodeCop This is a specific static-code-analysis group (AA) ships-in-future-update The issue is fixed in our 'master' branch and will ship in the next PREVIEW release

Comments

@NKarolak
Copy link

NKarolak commented Jul 4, 2024

Please include the following with each issue:

1. Describe the bug
Rule AA0234 is not activated the way we know it from other rules, inconsistently. Bug or feature for all new rules to come?

2. To Reproduce
By default, rule AA0234 is set to action Warning, as we can see in the docs, and in the AZ AL DevTools Code Analyzers view:
image

This usually means, that this rule is active. But it isn't. Steps to reproduce the behavior:

  1. In your app without any tooltips on table label fields, update your app.json to runtime 13.0. No warning AA0234.
  2. Add the rule to your project ruleset file. Only after that, warnings AA0234 appear as expected.

I know that this is by design as per docs:
image
But when you instruct to "enable the rule", I'd assume to find it first in disabled state - not in state "Warning", but for some weird reasons not working :-/

3. Expected behavior
The rule should be simply action = Hidden by default.

4. Actual behavior
The rule is Warning by default, but is in fact not active until we add it to a ruleset. I don't understand why it was solved that way.

5. Versions:

  • AL Language: 13.1.1065068 / runtime 13.0
  • AZ AL Dev Tools/AL Code Outline 13.67.0
    Internal work item: AB#540883
@thpeder
Copy link
Member

thpeder commented Jul 10, 2024

Hi @NKarolak,

Thanks for the issue.
We will make sure it is aligned with the other rules

@thpeder thpeder added CodeCop This is a specific static-code-analysis group (AA) accepted labels Jul 10, 2024
@NKarolak
Copy link
Author

This also applies to rule AA0247. It is actually an info, but in reality it's disabled.

@NKarolak
Copy link
Author

@thpeder Any news on this?

@NKarolak
Copy link
Author

NKarolak commented Sep 11, 2024

I've just found out that AA0234 also fires on missing table field tooltips even if a table object or table field are

  • ObsoleteState = Removed
  • Access = Internal
  • AllowInCustomizations = Never

Could you please fix that as well?

@krupybalu
Copy link

Hi @NKarolak,

We have aligned the rule with the other similar ones (that is DefaultSeverity=Info and IsEnabledByDefault=false).

Please note that we distinguish between a rule being disabled or having its default severity set to Hidden. This distinction can be influenced by several factors, such as performance considerations (since Hidden diagnostics are computed while disabled ones are not) or the diagnostic serving as an entry point for a code action (as Hidden diagnostics still show up on hover).

Please open a new case for the AA0234 problem and any further issues that you encounter. Thank you!

@JesperSchulz JesperSchulz added the ships-in-future-update The issue is fixed in our 'master' branch and will ship in the next PREVIEW release label Sep 26, 2024
@JesperSchulz
Copy link

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 26.0.23829.0 and VS Code Extension Version 15.0.1128421.

If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo

For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://freddysblog.com/2020/06/25/working-with-artifacts/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted CodeCop This is a specific static-code-analysis group (AA) ships-in-future-update The issue is fixed in our 'master' branch and will ship in the next PREVIEW release
Projects
None yet
Development

No branches or pull requests

4 participants