Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UWP] JSON parsing performance #4202

Closed
chriche-ms opened this issue Jun 22, 2020 · 1 comment · Fixed by #4203
Closed

[UWP] JSON parsing performance #4202

chriche-ms opened this issue Jun 22, 2020 · 1 comment · Fixed by #4203
Labels
Area-Performance Tracking issues around perf/renderer latency etc Bug Platform-XAML Bugs or features related to Xaml Renderer
Milestone
20.06

Comments

@chriche-ms
Copy link
Member

Platform

  • Android
  • iOS
  • UWP

Author or host

Author and host. Cortana in Windows - app is both an author and host.

Version of SDK

Nuget 1.2.8

Details

CPU profiling suggests performance of the C++ JSON parsing code can be improved as time is spent unnecessarily converting strings to stringstream objects and back again.
@chriche-ms chriche-ms added the Bug label Jun 22, 2020
@ghost ghost added the Triage-Needed label Jun 22, 2020
@chriche-ms chriche-ms mentioned this issue Jun 22, 2020
Merged
@shalinijoshi19 shalinijoshi19 added this to the 20.06 milestone Jun 22, 2020
@shalinijoshi19 shalinijoshi19 added the Area-Performance Tracking issues around perf/renderer latency etc label Jun 22, 2020
@chriche-ms chriche-ms mentioned this issue Jun 24, 2020
Merged
@shalinijoshi19 shalinijoshi19 added AdaptiveCards v1.2.10 Platform-XAML Bugs or features related to Xaml Renderer labels Jul 6, 2020
@ghost
Copy link

ghost commented Jul 8, 2020 •
edited by shalinijoshi19
Loading

🎉AdaptiveCards@v1.2.10 has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Performance Tracking issues around perf/renderer latency etc Bug Platform-XAML Bugs or features related to Xaml Renderer
Projects
None yet
Milestone
20.06
Development

Successfully merging a pull request may close this issue.

Improve C++ JSON parsing performance chriche-ms/AdaptiveCards
2 participants
@shalinijoshi19 @chriche-ms