Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][Image Rendering] Cards are too long when added Image via ResourceResolver #4349

Closed
akaashdev opened this issue Jul 10, 2020 · 5 comments · Fixed by #4367
Closed

[iOS][Image Rendering] Cards are too long when added Image via ResourceResolver #4349

akaashdev opened this issue Jul 10, 2020 · 5 comments · Fixed by #4367
Labels
Bug Partner-CiscoWebEx Bugs impacting CiscoWebEx integration scenarios

Comments

@akaashdev
Copy link
Contributor

Platform

  • iOS

Details

The ACRContentHoldingUIView takes the height of the image when inserted via ResourceResolver, which results in long cards.

Steps to reproduce

  • Setup a ResourceResolver by confirming to ACOIResourceResolver protocol
  • Return an UIImageView imgView in the protocol method func resolveImageViewResource(_ url: URL?) -> UIImageView?
  • Set an image of size say 960x540 in imgView later.

Screenshots

Simulator Screen Shot - iPhone 11 Pro - 2020-07-09 at 17 31 50

Simulator Screen Shot - iPhone 11 - 2020-07-10 at 12 50 24

Debugger Screenshots

Screenshot 2020-07-10 at 12 43 31 PM

Screenshot 2020-07-10 at 12 47 43 PM

@akaashdev akaashdev added the Bug label Jul 10, 2020
@ghost ghost added the Triage-Needed label Jul 10, 2020
@jwoo-msft
Copy link
Member

@akaashdev
Thanks for reporting the issue.
Can you share the payload? I'm interested in getting the URL to the image, so I can try from my end. Could I also know fillMode you used?

@akaashdev
Copy link
Contributor Author

@jwoo-msft
payloads.zip
These are the payloads of the above attached cards. Regarding the URL of the image, We re-host the image in our servers internally and I don't think so it will be accessible. It is for this reason we use ResourceResolvers. We use custom URLs (similar to those in the attached payloads) passed in the payload, to get necessary ids and infos to download the image.

card-images.zip
These are the downloaded images. Hope this helps.

Regarding the fillMode, I'm not really sure. I have noticed this issue in many cards with images.
Have noticed this sizing issue in sample cards like WeatherLarge as well, when image is inserted via ResourceResolver flow.

@ghost
Copy link

ghost commented Jul 13, 2020

Hi @akaashdev. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@jwoo-msft
Copy link
Member

@jwoo-msft
payloads.zip
These are the payloads of the above attached cards. Regarding the URL of the image, We re-host the image in our servers internally and I don't think so it will be accessible. It is for this reason we use ResourceResolvers. We use custom URLs (similar to those in the attached payloads) passed in the payload, to get necessary ids and infos to download the image.

card-images.zip
These are the downloaded images. Hope this helps.

Regarding the fillMode, I'm not really sure. I have noticed this issue in many cards with images.
Have noticed this sizing issue in sample cards like WeatherLarge as well, when image is inserted via ResourceResolver flow.

thanks. I have everything I need.

@shalinijoshi19 shalinijoshi19 added the Partner-CiscoWebEx Bugs impacting CiscoWebEx integration scenarios label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Partner-CiscoWebEx Bugs impacting CiscoWebEx integration scenarios
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants