[nodejs][Keyboard shortcut] Ctrl+Enter not working when inlineAction associated with a text.input

[scottlovegrove]

Platform

What platform is your issue or question related to? (Delete other platforms).

• JavaScript

Author or host

Host, using the SDK to render adaptive cards ourselves

SDK version 2.0.0 on npm

Details

When having an inlineAction set against a Text.Input, pressing ctrl+enter with the keyboard when in the input field should trigger the inline action, right now, it is not.

This is seen in Chrome (v84.0.4147.125), haven't tried this in other browsers, but would imagine it's the same.

[scottlovegrove]

In my own project, I had to use e.ctrlKey && e.charCode === 13 && this.inlineAction as my condition. I have created a fix for this, but I'm unsure whether to submit because apparently charCode is deprecated and code should be used, but that doesn't appear in my types as an available option 🤷‍♂️

[shalinijoshi19]

Thanks for raising and proposing the fix. @dclaux/ @paulcam206 thoughts?

[dclaux]

@scottlovegrove I am able to repro this in Firefox, thanks for reporting and for proposing a fix. charCode is non-standard and deprecated though, so we can't use it. But so is keyCode which the code currently uses. The guidance is to use KeyboardEvent.code instead. While it is not supported in IE, I believe it is an OK compromise.

Could you update your change to use KeyboardEvent.code and make sure it works across browsers?

[scottlovegrove]

Could you update your change to use KeyboardEvent.code and make sure it works across browsers?

@dclaux The problem I have here is that although the guidance is to use KeyboardEvent.code, I can't actually find any typescript type definitions that include this, so couldn't this end up breaking a build somewhere?

[shalinijoshi19]

@dclaux bringing this up to your attention.

[dclaux]

@scottlovegrove not sure what version of TypeScript you're using, but KeyboardEvent.code does show up for me:

[ghost]

🎉AdaptiveCards@2020.09 has been released which fixes this issue.:tada:

Handy links:

• Release Notes
• AdaptiveCards Website
• Official NPM Designer Release
• Official NPM Templating Release
• Official NPM Renderer Release
• Official Nuget Templating Release
• Official Nuget Renderer Release
• Official Maven Renderer Release
• Official CocoaPod Renderer Release