Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All][Consistency] Parsing Array Should Not Throw Exceptions #4837

Closed
6 tasks
jwoo-msft opened this issue Sep 28, 2020 · 3 comments
Closed
6 tasks

[All][Consistency] Parsing Array Should Not Throw Exceptions #4837

jwoo-msft opened this issue Sep 28, 2020 · 3 comments
Assignees
@jwoo-msft
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug

Comments

@jwoo-msft
Copy link
Member

Platform

  • .NET HTML
  • .NET WPF
  • Android
  • iOS
  • JavaScript
  • UWP

Details

Similar to #4834. If #4834 focused on string parsing. This issue focuses on parsing Array. When json array is parsed, and it is part of the required properties of AdaptiveCards, the parsers should not throw, but log parse error. Renderers should also make sure the adaptive elements with missing required array properties are dropped, and log renderer warning. For more detailed process, look this dev spec. The parsers should not throw, for example, if ColumnSet does not have columns.

Reference #4565
Childe of 4565

Related Issues

#4297
#3949
#4136
@jwoo-msft jwoo-msft added the Bug label Sep 28, 2020
@ghost ghost added this to the 20.10 milestone Sep 28, 2020
@ghost ghost added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Sep 28, 2020
@ghost
Copy link

ghost commented Sep 28, 2020

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

@ghost ghost added the High Priority label Sep 28, 2020
@ghost ghost added the Triage-Needed label Sep 28, 2020
@jwoo-msft jwoo-msft mentioned this issue Sep 28, 2020
Closed
29 tasks
@ghost
Copy link

ghost commented Sep 30, 2020

Hi @jwoo-msft. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@RebeccaAnne RebeccaAnne modified the milestones: 20.10, 20.11 Oct 13, 2020
@ghost ghost added the AdaptiveCards v20.11 label Nov 5, 2020
@RebeccaAnne RebeccaAnne modified the milestones: 20.11, Backlog Nov 10, 2020
@ghost ghost removed the AdaptiveCards v20.11 label Nov 10, 2020
@RebeccaAnne RebeccaAnne removed this from the Backlog milestone May 6, 2021
@RebeccaAnne
Copy link
Contributor

This is now tracked by Epic #6015 and it's child tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwoo-msft jwoo-msft

Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonmill @jwoo-msft @RebeccaAnne