Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate and add a sender that uses fetch when XMLHttpRequest is not available #1268

Closed
MSNev opened this issue May 13, 2020 · 2 comments
Closed

Investigate and add a sender that uses fetch when XMLHttpRequest is not available #1268

MSNev opened this issue May 13, 2020 · 2 comments
Assignees
@MSNev
Labels
enhancement p2 released - NPM service-worker Required to properly support service workers
Milestone
2.6.3

Comments

@MSNev
Copy link
Collaborator

MSNev commented May 13, 2020 •
edited
Loading

The sender codes does not include a fetch sender, so if you have not configured the beacon sender and XmlHttpRequest is not available (web workers) then the requests won't get sent.

The issue with the beacon sender is that it's a fire and forget situation, so if the server fails to accept the request the telemetry events are lost.

We should also add the ability for the user to provide extra headers
@MSNev MSNev mentioned this issue May 13, 2020
Closed
@MSNev MSNev self-assigned this May 13, 2020
@MSNev MSNev added the p2 label Jan 29, 2021
@MSNev MSNev mentioned this issue Jan 29, 2021
Closed
@MSNev MSNev added the service-worker Required to properly support service workers label Jan 29, 2021
@MSNev MSNev mentioned this issue Apr 23, 2021
Closed
@xiao-lix xiao-lix mentioned this issue Apr 27, 2021
Merged
@MSNev MSNev added this to the 2.x.x (Next) milestone Apr 29, 2021
@xiao-lix xiao-lix added the fixed - waiting release PR Committed and waiting deployment label Apr 29, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Jun 10, 2021

v2.6.3 is now fully deployed

@MSNev MSNev closed this as completed Jun 10, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
enhancement p2 released - NPM service-worker Required to properly support service workers
Projects
None yet
Milestone
2.6.3
Development

No branches or pull requests
2 participants
@xiao-lix @MSNev