IConfig.appUserId appears to be unused?

[AtOMiCNebula]

Not sure if I'm missing something subtle here, but while looking at some of the API docs and the code itself, IConfig.appUserId appears to be set in a few places, but never actually read. I had assumed, due to its proximity to IConfig.accountId, that it was related to AppInsights.setAuthenticatedUserContext, but it appears to not be the case.

If this is indeed dead code, I'd be happy to submit a PR to clean it up. If it's not dead code, I'm prepared to be enlightened. Thanks either way! :)

[KamilSzostak]

It looks like you can set "appUserId" in the snippet header but this field is not included in a telemetry.

@MaxShehovtsov do you know why we have 'appUserId" field? Is it safe to remove it?

    <script type="text/javascript">
        var appInsights=window.appInsights||function(config){ ....  }({
            instrumentationKey: "<your-key>",
            appUserId: "customUserId"
        });
        (....)
    </script>

[abaranch]

Per my understanding we had old API where userId and accountId could be set in the snippet. setAuthenticatedUserContext was added later. Account id still can be used and was preserved for backward compatibility but user id is not used now from anywhere. So it should be safe to remove.

[KamilSzostak]

PR: #142

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.