Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] enableAutoRouteTracking should also update the Operation Name with the hashroute #1393

Closed
markwolff opened this issue Oct 2, 2020 · 4 comments
Closed

[BUG] enableAutoRouteTracking should also update the Operation Name with the hashroute #1393

markwolff opened this issue Oct 2, 2020 · 4 comments
Assignees
@markwolff
Labels
bug good first issue released - NPM
Milestone
2.6.2

Comments

@markwolff
Copy link
Contributor

Description/Screenshot
enableAutoRouteTracking: true should update ai.operation.name to include the hashroute in the pathname

ApplicationInsights-JS/extensions/applicationinsights-analytics-js/src/JavaScriptSDK/ApplicationInsights.ts

Lines 650 to 653 in ae71ebf

if (_self._properties && _self._properties.context && _self._properties.context.telemetryTrace) {
_self._properties.context.telemetryTrace.traceID = Util.generateW3CId();
_self._properties.context.telemetryTrace.name = _location && _location.pathname || "_unknown_";
}

@markwolff markwolff self-assigned this Oct 2, 2020
@xiao-lix xiao-lix mentioned this issue Mar 24, 2021
Merged
@MSNev MSNev added this to the 2.x.x (Next Release) milestone Mar 31, 2021
@xiao-lix
Copy link
Contributor

Fixed with #1510

@MSNev
Copy link
Collaborator

MSNev commented Mar 31, 2021

Re-opening for release tracking with status

@MSNev MSNev reopened this Mar 31, 2021
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Mar 31, 2021
@MSNev
Copy link
Collaborator

MSNev commented Apr 27, 2021

v2.6.2 is now fully deployed

@MSNev MSNev closed this as completed Apr 27, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markwolff markwolff

Labels
bug good first issue released - NPM
Projects
None yet
Milestone
2.6.2
Development

No branches or pull requests
3 participants
@markwolff @xiao-lix @MSNev