Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] PageViewPerformanceManager.populatePageViewPerformanceEvent() is always returning zero for the network time #1440

Closed
MSNev opened this issue Dec 3, 2020 · 3 comments · Fixed by #1531

Comments

@MSNev
Copy link
Collaborator

MSNev commented Dec 3, 2020

In the populatePageViewPerformanceEvent method of PageViewPerformanceManager there are a couple of issues that need addressing.

  1. For Browsers that support the Navigation Timing perf event the calculation of the "networkConnect" time via
    var network = DateTimeUtils.GetDuration(navigationTiming.startTime, navigationTiming.connectEnd);
    is always zero as the GetDuration() only returns a value if BOTH start and end are not zero, null or undefined, however, the startTime (according to https://developer.mozilla.org/en-US/docs/Web/API/PerformanceNavigationTiming) is now always zero
  2. The scoping of the variables total, network, request, response, dom are incorrect, while the code seems to be working (with the current version) we should fix the scoping of these variables so they are not "defined" in the if / else clause to avoid a future break by a version of TypeScript, Uglify or browser JS implementation.
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 15, 2021

Reopening for release tracking

@MSNev MSNev reopened this Apr 15, 2021
@MSNev MSNev added this to the 2.x.x (Next Release) milestone Apr 15, 2021
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Apr 15, 2021
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 27, 2021

v2.6.2 is now fully deployed

@MSNev MSNev closed this as completed Apr 27, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant