Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Cache the result of the getGlobal() to reduce the number of typeof expressions #1753

Closed
MSNev opened this issue Feb 1, 2022 · 4 comments
Assignees
Milestone

Comments

@MSNev
Copy link
Collaborator

MSNev commented Feb 1, 2022

This will also increase the version of the shims modules to 2.0.1

@MSNev MSNev added this to the 2.7.3 milestone Feb 1, 2022
@MSNev MSNev self-assigned this Feb 1, 2022
@MSNev
Copy link
Collaborator Author

MSNev commented Feb 1, 2022

Including fix as part of #1752

@MSNev MSNev added fixed - waiting release PR Committed and waiting deployment released - NPM and removed fixed - waiting release PR Committed and waiting deployment labels Feb 1, 2022
@MSNev
Copy link
Collaborator Author

MSNev commented Feb 1, 2022

Shims v2.0.1 released to npm

@MSNev
Copy link
Collaborator Author

MSNev commented Feb 3, 2022

Deploying to final CDN endpoint

@MSNev MSNev closed this as completed Feb 3, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant