Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]urlCollectQuery not work for applicationinsights-clickanalytics-js #1863

Closed
lingfeidiewu opened this issue Jul 25, 2022 · 4 comments
Closed

Comments

@lingfeidiewu
Copy link

Description/Screenshot
In the ReadMe of applicationinsights-clickanalytics-js, there are two configuration urlCollectQuery and urlCollectHash. But after I set these two configuration as true, the uri in the event data still doesn't include the query string in url. I also cannot find any code related to urlCollectQuery in the repository. Are these two configurations useful to collect query string in url for auto captured click events?

@MSNev
Copy link
Collaborator

MSNev commented Jul 25, 2022

Looking at the code, I'm not finding any references to these properties -- looks like they got removed before the project was released. I don't have the details on why, will need to assign someone to investigate further...

@lingfeidiewu Right now, No these two configurations are not useful, at the very minimum this is a documentation bug. But we may be able to do something.

@Karlie-777, I'll raise a task and assign for August review.

@lingfeidiewu
Copy link
Author

Thanks. I think these two configurations are needed, now the query string are discarded in the click events data.

@Karlie-777
Copy link
Contributor

Karlie-777 commented Aug 3, 2022

The configs are removed in this PR: #1444
And the changes on Readme are back in PR: #1455 due to auto merge

@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Aug 3, 2022
@MSNev MSNev added this to the 2.8.7 milestone Aug 3, 2022
@MSNev MSNev closed this as completed Sep 14, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants