Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enableAutoRouteTracking has wrong page name #967

Closed
vishwam opened this issue Jul 11, 2019 · 2 comments
Closed

enableAutoRouteTracking has wrong page name #967

vishwam opened this issue Jul 11, 2019 · 2 comments

Comments

@vishwam
Copy link

vishwam commented Jul 11, 2019 •
edited
Loading

Version: 2.1.0

PageView events emitted via enableAutoRouteTracking are logged before the SPA code has the chance to change the title, so they currently end up with name=old title, url=new url.

Can you please add a timeout before the event is logged, similar to the react plugin ?

(This should ideally also be changed to use window.requestIdleCallback if available so we don't block the SPA rendering)
@markwolff markwolff mentioned this issue Jul 11, 2019
Merged
@markwolff
Copy link
Contributor

Thanks for the report. Fixed in 2.1.1

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vishwam @markwolff