Map service.version to application_Version (#1397)

microsoft · Dec 2, 2020 · 4a1762e · 4a1762e
1 parent 249778e
commit 4a1762e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/...t/applicationinsights/extensibility/initializer/ResourceAttributesContextInitializer.java b/...t/applicationinsights/extensibility/initializer/ResourceAttributesContextInitializer.java
@@ -43,7 +43,12 @@ public ResourceAttributesContextInitializer(Map<String, String> resourceAttribut
     @Override
     public void initialize(TelemetryContext context) {
         for (Map.Entry<String, String> entry: resourceAttributes.entrySet()) {
-            context.getProperties().put(entry.getKey(), substitutor.replace(entry.getValue()));
+            String key = entry.getKey();
+            if (key.equals("service.version")) {
+                context.getComponent().setVersion(substitutor.replace(entry.getValue()));
+            } else {
+                context.getProperties().put(key, substitutor.replace(entry.getValue()));
+            }
         }
     }
 }
diff --git a/test/smoke/appServers/global-resources/customdimensions_applicationinsights.json b/test/smoke/appServers/global-resources/customdimensions_applicationinsights.json
@@ -2,6 +2,7 @@
   "connectionString": "InstrumentationKey=00000000-0000-0000-0000-0FEEDDADBEEF;IngestionEndpoint=http://fakeingestion:60606/",
   "customDimensions": {
     "test": "value",
-    "home": "${HOME}"
+    "home": "${HOME}",
+    "service.version": "123"
   }
 }
diff --git a/.../src/smokeTest/java/com/microsoft/applicationinsights/smoketest/CustomDimensionsTest.java b/.../src/smokeTest/java/com/microsoft/applicationinsights/smoketest/CustomDimensionsTest.java
@@ -24,6 +24,8 @@ public void doMostBasicTest() throws Exception {
         assertEquals("value", rd.getProperties().get("test"));
         assertEquals("/root", rd.getProperties().get("home"));
 
+        assertEquals("123", rdEnvelope.getTags().get("ai.application.ver"));
+
         assertTrue(rd.getSuccess());
     }
 }