Reduce spammy logging (#1915)

* Reduce spammy logging * Update submodule * Azure sdk too
microsoft · Oct 15, 2021 · c0d9719 · c0d9719
1 parent e7b7aa6
commit c0d9719
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 5 deletions.
diff --git a/.../java/com/microsoft/applicationinsights/agent/internal/init/LoggingLevelConfigurator.java b/.../java/com/microsoft/applicationinsights/agent/internal/init/LoggingLevelConfigurator.java
@@ -46,6 +46,8 @@ public void initLoggerLevels(LoggerContext loggerContext) {
     updateLoggerLevel(loggerContext.getLogger("io.grpc.Context"));
     updateLoggerLevel(loggerContext.getLogger("io.opentelemetry"));
     updateLoggerLevel(loggerContext.getLogger("muzzleMatcher"));
+    updateLoggerLevel(
+        loggerContext.getLogger("com.azure.core.implementation.jackson.JacksonVersion"));
     updateLoggerLevel(loggerContext.getLogger("com.microsoft.applicationinsights"));
     updateLoggerLevel(loggerContext.getLogger(ROOT_LOGGER_NAME));
   }
@@ -54,8 +56,7 @@ public void updateLoggerLevel(Logger logger) {
     Level loggerLevel;
     String name = logger.getName();
     if (name.startsWith("reactor.netty") || name.startsWith("io.netty")) {
-      // never want to log reactor netty or netty at trace or debug, it's just way too verbose
-      loggerLevel = getAtLeastInfoLevel(level);
+      loggerLevel = getNettyLevel(level);
     } else if (name.startsWith("io.grpc.Context")) {
       // never want to log io.grpc.Context at trace or debug, as it logs confusing stack trace that
       // looks like error but isn't
@@ -68,6 +69,10 @@ public void updateLoggerLevel(Logger logger) {
       // muzzleMatcher logs at WARN level, so by default this is OFF, but enabled when DEBUG logging
       // is enabled
       loggerLevel = getMuzzleMatcherLevel(level);
+    } else if (name.startsWith("com.azure.core.implementation.jackson.JacksonVersion")) {
+      // need to suppress ERROR messages from this class since it cannot find the real jackson
+      // version due to shading
+      loggerLevel = Level.OFF;
     } else if (name.startsWith("com.microsoft.applicationinsights")) {
       loggerLevel = level;
     } else {
@@ -81,9 +86,27 @@ private static Level getAtLeastInfoLevel(Level level) {
     return getMaxLevel(level, Level.INFO);
   }
 
+  private static Level getNettyLevel(Level level) {
+    if (level == Level.DEBUG || level == Level.TRACE) {
+      // never want to log reactor netty or netty at trace or debug, it's just way too verbose
+      return Level.INFO;
+    } else if (level == Level.INFO || level == Level.WARN) {
+      // suppress spammy reactor-netty WARN logs
+      return Level.ERROR;
+    } else {
+      return level;
+    }
+  }
+
   private static Level getOpenTelemetryLevel(Level level) {
-    // bump DEBUG up to INFO, keep all others as-is
-    return level == Level.DEBUG ? Level.INFO : level;
+    if (level == Level.INFO) {
+      return Level.WARN;
+    } else if (level == Level.DEBUG) {
+      // use "trace" level to enable verbose debugging
+      return Level.INFO;
+    } else {
+      return level;
+    }
   }
 
   private static Level getOtherLibLevel(Level level) {

diff --git a/otel b/otel
+13 −0		instrumentation/internal/internal-reflection/javaagent-integration-tests/src/test/groovy/ReflectionTest.groovy
+10 −3		...avaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/reflection/ReflectionHelper.java
+2 −2		javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/context/FieldBackedProvider.java