Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransmissionNetworkOutput sending loop should delay for all exceptions and not dispose connection all the time #385

Closed
SergeyKanzhelev opened this issue Jun 9, 2017 · 3 comments
Labels
Milestone

Comments

@SergeyKanzhelev
Copy link
Contributor

There are other exceptions that needs delay for the next loop. Otherwise on azure web apps SDK takes out all the available connections.

https://github.com/Microsoft/ApplicationInsights-Java/blob/master/core/src/main/java/com/microsoft/applicationinsights/internal/channel/common/TransmissionNetworkOutput.java#L131

@beckylino beckylino added this to the future milestone Aug 2, 2017
@dhaval24
Copy link
Contributor

@SergeyKanzhelev the delay mechanism is now in place for all the exceptions. Please check latest master if interested. Quick question though, I see that current default backoff time is set o 300 sec which can be sometimes too much in high throughput applications. We have seen this with some of the users resulting in lost telemetry. A dirty fix was to have 3 immediate retries before going to 300 seconds backoff. This would be fix unblocking several people though something else could be ideal. Let me know your thoughts and I would be closing this one.

@SergeyKanzhelev
Copy link
Contributor Author

spin-lock's like retries sounds good. I remember I caused this connections starvation when I had some packages mismatch and it kept failing for me with the exception un-expected in code. If this is fixed - great, please close the issue.

@dhaval24
Copy link
Contributor

@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants