Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to otel 0.17.0 #1504

Merged
merged 7 commits into from
Feb 23, 2021
Merged

Update to otel 0.17.0 #1504

merged 7 commits into from
Feb 23, 2021

Conversation

trask
Copy link
Member

@trask trask commented Feb 20, 2021

No description provided.

@trask trask mentioned this pull request Feb 20, 2021
Merged
@trask trask force-pushed the trask/update-to-otel-0.17.0 branch from 23bfde8 to 782f8db Compare February 20, 2021 21:30
@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2021

This pull request fixes 2 alerts when merging b04e166 into 5a75d6d - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2021

This pull request fixes 2 alerts when merging 4b97798 into 5a75d6d - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@trask trask force-pushed the trask/update-to-otel-0.17.0 branch from 4b97798 to 13f1d42 Compare February 21, 2021 04:14
@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2021

This pull request fixes 2 alerts when merging 13f1d42 into 5a75d6d - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@trask trask force-pushed the trask/update-to-otel-0.17.0 branch from 13f1d42 to 639748b Compare February 21, 2021 18:22
@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2021

This pull request fixes 2 alerts when merging 639748b into 5a75d6d - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@trask trask mentioned this pull request Feb 22, 2021
Merged
@trask
Copy link
Member Author

trask commented Feb 22, 2021

Draft for now. #1505 needs to be merged first.

@trask trask force-pushed the trask/update-to-otel-0.17.0 branch from 639748b to 2837580 Compare February 22, 2021 21:20
@lgtm-com
Copy link

lgtm-com bot commented Feb 22, 2021

This pull request fixes 2 alerts when merging 2837580 into 2e0b120 - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@trask trask marked this pull request as ready for review February 22, 2021 21:57
trask
trask commented Feb 23, 2021
View reviewed changes
agent/agent-tooling/spotbugs.exclude.xml
</Match>
<Match>
<Bug pattern="CRLF_INJECTION_LOGS" />
<Class name="com.microsoft.applicationinsights.agent.internal.wasbootstrap.MainEntryPoint" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename wasbootstrap

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rename in separate PR, it's an internal package and so many changes in this PR already

...om/microsoft/applicationinsights/agent/internal/wasbootstrap/AiBootstrapPackageProvider.java Outdated Show resolved Hide resolved
agent/instrumentation/build.gradle Outdated Show resolved Hide resolved
heyams
heyams approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@heyams heyams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lgtm-com
Copy link

lgtm-com bot commented Feb 23, 2021

This pull request fixes 2 alerts when merging 661537d into db61201 - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@lgtm-com
Copy link

lgtm-com bot commented Feb 23, 2021

This pull request fixes 2 alerts when merging 6ea3e71 into db61201 - view on LGTM.com

fixed alerts:

  • 2 for Potential input resource leak

@trask trask merged commit 34e3bec into master Feb 23, 2021
@trask trask deleted the trask/update-to-otel-0.17.0 branch February 23, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyams heyams heyams approved these changes

@kryalama kryalama Awaiting requested review from kryalama

@xiao-lix xiao-lix Awaiting requested review from xiao-lix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @heyams