Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set role name lazily for Linux consumption plan #1537

Merged
merged 7 commits into from
Mar 11, 2021
Merged

Set role name lazily for Linux consumption plan #1537

merged 7 commits into from
Mar 11, 2021

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Mar 5, 2021

this is depended on #1536.

@heyams heyams marked this pull request as ready for review March 11, 2021 03:09
trask
trask approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit cc8b707 into master Mar 11, 2021
@heyams heyams deleted the heya/ai-website-site-name branch March 16, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@kryalama kryalama Awaiting requested review from kryalama

@xiao-lix xiao-lix Awaiting requested review from xiao-lix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyams @trask