Fix service bus mapping #1848
Merged
Fix service bus mapping #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
fix-service-bus-mapping
branch
from
9e73051 to
0f7c2d0
Compare
heyams
reviewed
Aug 16, 2021
|
|
||
| private static final OperationLogger exportingSpanLogger = | ||
| new OperationLogger(Exporter.class, "Exporting span"); | ||
|
|
||
| private static final OperationLogger parsingHttpUrlLogger = | ||
| new OperationLogger(Exporter.class, "Parsing http.url"); | ||
|
|
||
| static { | ||
| Set<String> dbSystems = new HashSet<>(); |
There was a problem hiding this comment.
does otel java sdk have dbSystems defined already? can we refer to that directly if it becomes available? i remember there is a common spec for dbsystems on the otel spec repo.
|
|
||
| // TODO need to keep this list in sync as new semantic conventions are defined | ||
| // TODO make this opt-in for javaagent | ||
| Set<String> standardAttributesPrefix = new HashSet<>(); |
There was a problem hiding this comment.
same here.. i feel that otel should take care of all the standard attribute prefixes.
There was a problem hiding this comment.
unfortunately there are no otel constants we can use for this, at least not yet
heyams
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @lmolkova's Azure/azure-sdk-for-java#21668 (comment) and Azure/azure-sdk-for-java#21668 (review)