Quick Pulse cleanup and add sample telemetry feature #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Aug 24, 2021
...rc/main/java/com/microsoft/applicationinsights/agent/internal/httpclient/LazyHttpClient.java
Outdated
Show resolved
Hide resolved
.../java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulseDataFetcher.java
Outdated
Show resolved
Hide resolved
...n/java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulsePingSender.java
Outdated
Show resolved
Hide resolved
...n/java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulsePingSender.java
Outdated
Show resolved
Hide resolved
...ava/com/microsoft/applicationinsights/agent/internal/quickpulse/model/QuickPulseMetrics.java
Outdated
Show resolved
Hide resolved
...com/microsoft/applicationinsights/agent/internal/quickpulse/util/CustomCharacterEscapes.java
Outdated
Show resolved
Hide resolved
kryalama
changed the title
tokaplan
reviewed
Aug 25, 2021
...ava/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulseDataCollector.java
Outdated
Show resolved
Hide resolved
...ava/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulseDataCollector.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private static Map<String, String> aggregateProperties( |
There was a problem hiding this comment.
C# SDK limits the maximum number of Properties and Measurements to 10. But if you feel this is not necessary here, I won't insist on it. Trask will probably have an opinion.
There was a problem hiding this comment.
If you do choose to limit the top count, make sure it's consistent, so sort them by name first, and then limit.
There was a problem hiding this comment.
@trask your thoughts on this? Nodejs sdk donot have this limit
There was a problem hiding this comment.
I think it's ok as-is for now, property/measurement explosion is not currently one of my worries, and we can revisit later
.../java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulseDataFetcher.java
Outdated
Show resolved
Hide resolved
...n/java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulsePingSender.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Aug 26, 2021
...ava/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulseDataCollector.java
Outdated
Show resolved
Hide resolved
.../java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulseDataFetcher.java
Show resolved
Hide resolved
...n/java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulsePingSender.java
Outdated
Show resolved
Hide resolved
.../java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulseDataFetcher.java
Show resolved
Hide resolved
...n/java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulsePingSender.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick Pulse cleanup
Add playback tests
Add Sample Telemetry feature to live metrics