Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry processor - Allow multimatch on log body and span name #3229

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Telemetry processor - Allow multimatch on log body and span name #3229

merged 7 commits into from
Aug 24, 2023

Conversation

jeanbisutti
Copy link
Member

No description provided.

@trask
Update agent/agent-tooling/src/main/java/com/microsoft/applicationins…
9176c09 
…ights/agent/internal/processors/ProcessorUtil.java
trask
trask reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it may make sense to capture multimatches in an attribute of type "string array" (to capture all of the values, instead of only the last value)

trask
trask reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about implementing different behavior for log body and span name

I think my preference would be to keep them consistent (either break neither, or break both)

@jeanbisutti jeanbisutti changed the title Allow multimatch for telemetry log processor Telemetry processor - Allow multimatch on log body and span name Aug 24, 2023
@jeanbisutti
Copy link
Member Author

jeanbisutti commented Aug 24, 2023 •
edited
Loading

Same behavior now applied on log body and span name

@trask trask merged commit 2d771fb into main Aug 24, 2023
@trask trask deleted the log-processor-multimatch branch August 24, 2023 17:40
@AnuragSingh-MSFT AnuragSingh-MSFT mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@heyams heyams Awaiting requested review from heyams heyams is a code owner

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeanbisutti @trask