Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control Document Quotas for QuickPulse #2425

Merged
merged 37 commits into from
Oct 27, 2021
Merged

Control Document Quotas for QuickPulse #2425

merged 37 commits into from
Oct 27, 2021

Conversation

rambhatt-msft
Copy link
Contributor

Fix Issue # .

Changes

(Please provide a brief description of the changes here.)

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

tokaplan
tokaplan requested changes Sep 28, 2021
View reviewed changes
Copy link
Member

@tokaplan tokaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's talk through this and do another round of changes.

WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs Outdated Show resolved Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs Outdated Show resolved Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs Outdated Show resolved Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs Outdated Show resolved Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs Outdated Show resolved Hide resolved
...ceCollector/PerformanceCollector/Implementation/QuickPulse/Helpers/QuickPulseQuotaTracker.cs Outdated Show resolved Hide resolved
...Collector/PerformanceCollector/Implementation/QuickPulse/QuickPulseCollectionStateManager.cs Outdated Show resolved Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs Show resolved Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryProcessor.cs Outdated Show resolved Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryProcessor.cs Show resolved Hide resolved
@rambhatt-msft rambhatt-msft marked this pull request as ready for review September 29, 2021 18:10
@rambhatt-msft rambhatt-msft changed the title [WIP] Control Document Quotas for QuickPulse Control Document Quotas for QuickPulse Sep 29, 2021
@TimothyMothra TimothyMothra added this to the 2.20 milestone Oct 21, 2021
@rambhatt-msft rambhatt-msft force-pushed the rambhatt/adjustable-document-quotas branch from f6dfc7c to 11fe028 Compare October 25, 2021 22:19
tokaplan
tokaplan requested changes Oct 26, 2021
View reviewed changes
WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryModuleTests.cs Outdated Show resolved Hide resolved
WEB/Src/PerformanceCollector/Perf.Tests/QuickPulse/QuickPulseTelemetryModuleTests.cs Show resolved Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs Outdated Show resolved Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs Outdated Show resolved Hide resolved
...anceCollector/PerformanceCollector/Implementation/Service contract/QuotaConfigurationInfo.cs Outdated Show resolved Hide resolved
...anceCollector/PerformanceCollector/Implementation/Service contract/QuotaConfigurationInfo.cs Outdated Show resolved Hide resolved
WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs Outdated
@@ -207,18 +205,24 @@ private void CreatePerformanceCounters(out CollectionConfigurationError[] errors
CollectionConfigurationError[] localErrors = null;
try
{
Tuple<float, float, float, float, float> initialQuotas;
previousQuotasByStreamId.TryGetValue(documentStreamInfo.Id, out initialQuotas);
previousQuotasByStreamId.TryGetValue(documentStreamInfo.Id, out Tuple<float, float, float, float, float> initialQuotas);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename initialQuotas in order to make it clear that it comes from the previous quota. Maybe previousQuotas or something like that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The out var name.

...ceCollector/PerformanceCollector/Implementation/QuickPulse/Helpers/QuickPulseQuotaTracker.cs Outdated Show resolved Hide resolved
...anceCollector/PerformanceCollector/Implementation/Service contract/QuotaConfigurationInfo.cs Outdated
@@ -0,0 +1,22 @@
namespace Microsoft.ApplicationInsights.Extensibility.PerfCounterCollector.Implementation.Service_contract
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In C#, namespace segments are PascalCase with no underscores or other special symbols. This should be ServiceContract

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's not old. The namespace is still called Service_contract.

WEB/Src/PerformanceCollector/PerformanceCollector/QuickPulseTelemetryProcessor.cs Show resolved Hide resolved
tokaplan
tokaplan requested changes Oct 26, 2021
View reviewed changes
...anceCollector/PerformanceCollector/Implementation/Service contract/QuotaConfigurationInfo.cs Outdated
@@ -0,0 +1,22 @@
namespace Microsoft.ApplicationInsights.Extensibility.PerfCounterCollector.Implementation.Service_contract
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's not old. The namespace is still called Service_contract.

tokaplan
tokaplan requested changes Oct 26, 2021
View reviewed changes
WEB/Src/PerformanceCollector/PerformanceCollector/CollectionConfiguration.cs Outdated
@@ -207,18 +205,24 @@ private void CreatePerformanceCounters(out CollectionConfigurationError[] errors
CollectionConfigurationError[] localErrors = null;
try
{
Tuple<float, float, float, float, float> initialQuotas;
previousQuotasByStreamId.TryGetValue(documentStreamInfo.Id, out initialQuotas);
previousQuotasByStreamId.TryGetValue(documentStreamInfo.Id, out Tuple<float, float, float, float, float> initialQuotas);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The out var name.

@TimothyMothra
Copy link
Member

Please also update the Changelog under the VNext section. :)

TimothyMothra
TimothyMothra approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update changelog

@TimothyMothra TimothyMothra mentioned this pull request Oct 27, 2021
Merged
@TimothyMothra TimothyMothra merged commit 2c9b722 into develop Oct 27, 2021
@TimothyMothra TimothyMothra deleted the rambhatt/adjustable-document-quotas branch October 27, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyMothra TimothyMothra TimothyMothra approved these changes

@tokaplan tokaplan tokaplan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.20
Development

Successfully merging this pull request may close these issues.
3 participants
@rambhatt-msft @TimothyMothra @tokaplan