Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Electron 29 #6952

Closed
Tracked by #7759
MRayermannMSFT opened this issue Jun 5, 2023 · 4 comments
Closed
Tracked by #7759

Update to Electron 29 #6952

MRayermannMSFT opened this issue Jun 5, 2023 · 4 comments
Assignees
@JasonYeMSFT
Labels
📦 electron update required Requires updating to a newer version of electron 🧪 engineering Related to some internal engineering improvements ✅ merged A fix for this issue has been merged
Milestone
1.34.0

Comments

@MRayermannMSFT
Copy link
Member

MRayermannMSFT commented Jun 5, 2023 •
edited
Loading

See UpdatingElectron.md for instructions.

Note: Electron 29 moves to Node 20. Make sure to look into our native modules (owned and not owned), and confirm that ServiceHub/IdentityService still works well.
@MRayermannMSFT MRayermannMSFT added 📦 electron update required Requires updating to a newer version of electron 🧪 engineering Related to some internal engineering improvements labels Jun 5, 2023
@MRayermannMSFT MRayermannMSFT added this to the 1.34.0 milestone Jun 5, 2023
@MRayermannMSFT MRayermannMSFT self-assigned this Jun 5, 2023
@alexweininger
Copy link
Member

ESM SUPPORT 🚀 🚀 🚀 🚀 electron/electron#21457

@MRayermannMSFT MRayermannMSFT changed the title Update to Electron 28 Update to Electron 29 Nov 22, 2023
@MRayermannMSFT MRayermannMSFT mentioned this issue Feb 22, 2024
Closed
@JasonYeMSFT
Copy link
Contributor

electron/electron#41518

@MRayermannMSFT
Copy link
Member Author

Need a v29 with fix for electron/electron#41484 / nodejs/node#48673

@JasonYeMSFT
Copy link
Contributor

Done upgrading to v29.2.0. We have no blocker in Electron v29 now. Depending on when v29.3.0 is made available, we may choose to upgrade or not.

@JasonYeMSFT JasonYeMSFT added the ✅ merged A fix for this issue has been merged label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JasonYeMSFT JasonYeMSFT

Labels
📦 electron update required Requires updating to a newer version of electron 🧪 engineering Related to some internal engineering improvements ✅ merged A fix for this issue has been merged
Projects
None yet
Milestone
1.34.0
Development

No branches or pull requests
4 participants
@alexweininger @MRayermannMSFT @JasonYeMSFT @richardMSFT