Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement costs in UI for workspace services and user resources #2932

Open
jjgriff93 opened this issue Nov 29, 2022 · 7 comments
Open

Implement costs in UI for workspace services and user resources #2932

jjgriff93 opened this issue Nov 29, 2022 · 7 comments
Assignees
Labels

Comments

@jjgriff93
Copy link
Collaborator

image

We should consider moving the costs display for individual resources into the information pane instead of displaying next to the button as this causes display issues and overcrowding in the resource card. @guybartal thoughts on this? Should the costs appear for user resources in the first place or is it supposed to be workspaces and services?

@jjgriff93 jjgriff93 added bug Something isn't working ui TRE UI labels Nov 29, 2022
@guybartal
Copy link
Contributor

Hi @jjgriff93 ,
I didn't implement workspace level costs yet, the cost tag shouldn't be visible there yet, but I've planned to implement it there as well, I agree with you, may be this should be moved to the information pane when you have action buttons.

@marrobi
Copy link
Member

marrobi commented Feb 28, 2023

@martinpeck think this is a duplicate of #3254 ?

@martinpeck
Copy link
Member

martinpeck commented Mar 1, 2023

I don't know. It's related, but I can't tell if this is a duplicate.

This issue was raised against a user resource, but the comment "I didn't implemented workspace level costs yet" doesn't entirely make sense (to me) in that context.

@guybartal are you able to comment on this?

@marrobi marrobi changed the title Resource card UI shows cost skeleton alongside connect button Implement costs in UI for workspace services and user resources Sep 21, 2023
@marrobi marrobi added feature and removed bug Something isn't working labels Sep 21, 2023
@marrobi
Copy link
Member

marrobi commented Sep 21, 2023

Looked into this today, resolved the grey box issue, but we still need the costs implementing into the UI once inside a workspace.

@marrobi marrobi self-assigned this Oct 9, 2023
@marrobi
Copy link
Member

marrobi commented Oct 10, 2023

This PR adds costs for workspace services and user resources, but not for Researchers as the API does not allow them access: https://github.com/microsoft/AzureTRE/actions/runs/6466536327/job/17554763014?pr=3733

@martinpeck
Copy link
Member

Did you mean to link to the PR?
(You've given a link to a broken build)

@marrobi
Copy link
Member

marrobi commented Oct 10, 2023

Try again #3733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

4 participants