Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor bug in Linux vm_config.sh? #4065

Closed
TonyWildish-BH opened this issue Aug 13, 2024 · 1 comment · Fixed by #4064
Closed

minor bug in Linux vm_config.sh? #4065

TonyWildish-BH opened this issue Aug 13, 2024 · 1 comment · Fixed by #4064
Labels
bug Something isn't working

Comments

@TonyWildish-BH
Copy link

Describe the bug
By inspection, there appears to be a minor bug in templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/vm_config.sh.

The end of the script has a "cleanup" which reboots the machine, but the script has code after that to prevent the screen timeout. That code is never going to be executed.

[...]
## Cleanup
echo "init_vm.sh: Cleanup"
sudo shutdown -r now

# Prevent screen timeout 
echo "init_vm.sh: Preventing Timeout"
sudo touch /home/"${VM_USER}"/.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-screensaver.xml
sudo chmod 664 /home/"${VM_USER}"/.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-screensaver.xml
sudo chown "${VM_USER}":"${VM_USER}" /home/"${VM_USER}"/.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-screensaver.xml
sudo tee /home/"${VM_USER}"/.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-screensaver.xml << END
<?xml version="1.0" encoding="UTF-8"?>
<channel name="xfce4-screensaver" version="1.0">
  <property name="saver" type="empty">
    <property name="mode" type="int" value="0"/>
    <property name="enabled" type="bool" value="false"/>
  </property>
  <property name="lock" type="empty">
    <property name="enabled" type="bool" value="false"/>
  </property>
</ channel>
END
@tim-allen-ck
Copy link
Collaborator

Hi @TonyWildish-BH that code does still get executed, I've checked the logs. There's a PR open to change how the system prevents the timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants