Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Verify docker credentials are not passed/stored #575

Closed
tamirkamara opened this issue Aug 8, 2021 · 0 comments · Fixed by #609
Closed

[Task] Verify docker credentials are not passed/stored #575

tamirkamara opened this issue Aug 8, 2021 · 0 comments · Fixed by #609
Assignees
@deniscep

Comments

@tamirkamara
Copy link
Collaborator

Story: #345

Description
Whenever possible we should pull docker images with managed-identities instead for the docker registry admin credentials.
Check out gitea shared service for an example (not of the difference in managed identity type)
@tamirkamara tamirkamara mentioned this issue Aug 8, 2021
Closed
@deniscep deniscep changed the title [Task] API pull docker images with Managed Identity [Task] Runner should pull docker images with Managed Identity Aug 11, 2021
@deniscep deniscep mentioned this issue Aug 11, 2021
Closed
2 tasks
@deniscep deniscep self-assigned this Aug 12, 2021
@deniscep deniscep changed the title [Task] Runner should pull docker images with Managed Identity [Task] Verify docker credentials are not passed/stored Aug 12, 2021
@deniscep deniscep mentioned this issue Aug 12, 2021
Merged
@deniscep deniscep linked a pull request Aug 12, 2021 that will close this issue
Removing docker registry username and pass from API config #609
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniscep deniscep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing docker registry username and pass from API config microsoft/AzureTRE
2 participants
@deniscep @tamirkamara