-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple BotManager and BotRuntime #1516
Comments
@luhan2017 let's discuss the technical design and how this will map to the custom schema/custom runtime approach. We may not need a BotManager interface and want to understand concretely how this plays with our long term strategy. |
@christopheranderson to provide some dotnet resources on process management |
Follow up with today's discussion, here is the previous issues
|
@boydc2014 , I am confused, seems the PR #47 already fixed the process can't be stopped issue. So we can just start and stop a bot by the mechanism in that PR, is this correct? |
@sangwoohaan need your suggestion from UX experience . Attached the spec as below. |
Currently local bot runtime and bot manager are tightly coupled, Bot manager is another endpoint in bot runtime which accepts a post request from composer. The payload contains all the bot resource files, Composer saves it at a local tmp folder and Reload that new bot. Please refer to this doc to see more details. How to connect to BotRuntime
#483 is one issue which is caused by the current mechanisim.
We want to decouple the BotManager and BotRuntime and make BotManager a built in component in Composer.
Design Principles
Design Doc
https://microsoft.sharepoint.com/:w:/t/ConversationalAI785/ET5w2rXKpldNvddO9447K3QBH9wfwbRPJM4DIGIRSUQHKg?e=rbymdb
BotManager
Implement BotManager within composer which have such functionalities:
BotManager maintains all the runtime status in Composer
BotRuntime
Bot Runtime should be a stand alone SDK bot template.
BotRuntime will just follow the protocals and implemented a start script.
Exceptions
TBD, Need to figure out a way to catch the runtime exceptions and show that to user.
Bot Dashboard
Add another page in composer to show an overview of the Bot Runtime Dashboard.
The text was updated successfully, but these errors were encountered: