Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QnA configuration - "Object reference not set to an instance of an object." #1591

Closed
2 of 7 tasks
WTobor opened this issue Nov 15, 2019 · 4 comments
Closed
2 of 7 tasks
Assignees
Labels
Area: Shell Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. not reproducible

Comments

@WTobor
Copy link

WTobor commented Nov 15, 2019

Version

branch master, commit 326026e

Browser

What browser are you using?

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

What operating system are you using?

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Create bot app from template "Luis & QnA"
  2. Create QnA knowledgebase
  3. In Settings add valid
  4. Update flow to use only Qna on start:
    image
  5. Open bot in Emulator

Current behaviour

image

Expected behavior

There is no error

Additional information

There is no error after steps:

  • copy qna node from BotProject/ComposerDialog/settings/appsettings.json to BotProject/appsettings.json
  • manually add missing endpointkey node in qna node
@WTobor WTobor added the Needs-triage A new issue that require triage label Nov 15, 2019
@hibrenda
Copy link
Contributor

hibrenda commented Nov 15, 2019

@WTobor Composer settings will be set into BotProject/ComposerDialog/settings/appsettings.json but not BotProject/appsettings.json . The latter one is for deployment usage.

  1. Confirm you have input everything under "qna" setting ?
    image

  2. Confirm the appsetting file has been correctly set
    With this fix: QnA Maker EndpointKey is null Issue #1571 integration, "endpointkey" should be persist into disk which located in BotProject/ComposerDialog/settings/appsettings.json . If you have settings updates successfully, files will be updated as well. Please confirm the file content. If you input something wrong in settings, editor will show error with red frame so the updated contents will not be saved and you might hit errors.

@WTobor
Copy link
Author

WTobor commented Nov 15, 2019

Yes, I can confirm.

@hibrenda
Copy link
Contributor

@WTobor Updated comment to check apsettings file (see above) , by the way for your dialog step in welcome, the QnA step won't be invoked in above flow. We'd better to have tirgger intent with utterance to invoke QnA.

@VanyLaw
Copy link
Contributor

VanyLaw commented Nov 18, 2019

Hi @WTobor I can't reproduce too. If you set those value correctly into settings, It should be persist to disk (ComposerDialog/settings/appsettings.json), and no need to manually add endpoingkey to file. Could you try again in the latest master branch?

FYI. this is the file I get in my localhost, which included endpointkey already.
image.

And the property name in settings should be the same as the value you filled in the form.
image
image

@Stevenic Stevenic added customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Shell Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. not reproducible
Projects
None yet
Development

No branches or pull requests

5 participants