Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use proxy config lsp server url #1753

Closed
zhixzhan opened this issue Dec 11, 2019 · 0 comments
Closed

use proxy config lsp server url #1753

zhixzhan opened this issue Dec 11, 2019 · 0 comments
Assignees
Labels
R8 Release 8 - March 16th, 2020

Comments

@zhixzhan
Copy link
Contributor

Is your feature request related to a problem? Please describe.

// lsp server port should be same with composer/server port.
const lspServerPort = process.env.NODE_ENV === 'production' ? process.env.PORT || 3000 : 5000;
const lspServerPath = '/lg-language-server';

Describe the solution you'd like
component should not aware those env, just always same with server url

Describe alternatives you've considered

  1. For development environment, use webpack-dev-server proxy lsp websocket request to server 5000;
  2. For production environment, it is current server url, nothing need to do.
@zhixzhan zhixzhan added the Needs-triage A new issue that require triage label Dec 11, 2019
@zhixzhan zhixzhan self-assigned this Dec 11, 2019
@zhixzhan zhixzhan added Type: Enhancement and removed Needs-triage A new issue that require triage labels Dec 11, 2019
@hibrenda hibrenda added the R8 Release 8 - March 16th, 2020 label Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R8 Release 8 - March 16th, 2020
Projects
None yet
Development

No branches or pull requests

3 participants