Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New File dialog is overly non-standard #2972

Closed
2 of 7 tasks
tomlm opened this issue May 9, 2020 · 4 comments
Closed
2 of 7 tasks

New File dialog is overly non-standard #2972

tomlm opened this issue May 9, 2020 · 4 comments
Assignees
Labels
P1 Painful if we don't fix, won't block releasing R9-RC Type: Bug Something isn't working

Comments

@tomlm
Copy link
Contributor

tomlm commented May 9, 2020

Describe the bug

I installed from github release page (0.0.1)

Version

0.0.1 (2 days ago)

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

  1. New Bot

Expected behavior

  1. It should have windows path, so it it should have \ instead of /
  2. It should start in the logged in Users folder, not the root.,
  3. It should not have slash before the drive letter.

Screenshots

image

Additional context

@tomlm tomlm added Type: Bug Something isn't working Needs-triage A new issue that require triage labels May 9, 2020
@cwhitten cwhitten added R9-RC P1 Painful if we don't fix, won't block releasing and removed Needs-triage A new issue that require triage labels May 10, 2020
@cwhitten
Copy link
Member

@liweitian can you take a look at this please?

In addition to @tomlm's Expected behavior, please also do the following:

  • Hide special/hidden directories in the navigation control

Directories with special prefixes like '$' or '.' should be filtered out.

Screen Shot 2020-05-10 at 10 18 01 AM

@boydc2014
Copy link
Contributor

boydc2014 commented May 11, 2020

@cwhitten we were kind of trying to unify the path in unix style to make it more convininent. So we are now getting to have different UI in win vs non-win, right? that could solve 1 and 3 in @tomlm's request.

And @tomlm, for 2, i see the default folder is C:\user\myusername\documents\Composer
image
Is this not the case in your side? what did you see without jumping into other folders, because we will use the location you accessed last time as the new default.

@cwhitten
Copy link
Member

cwhitten commented May 11, 2020

I like the consistency of the unix path for internal operations. We can maintain that if it is helpful. When we render the view can we consider a transform to the os path separator? This wouldn't require a change to the internal model of path serialization.

The request is to default to /Users/${username} instead of /Users/{username}/Documents

@boydc2014
Copy link
Contributor

I like the consistency of the unix path for internal operations. We can maintain that if it is helpful. When we render the view can we consider a transform to the os path separator? This wouldn't require a change to the internal model of path serialization.

The request is to default to /Users/${username} instead of /Users/{username}/Documents

Sorry for not following up this quickly, i saw this is closed,

Our previous our default path is /Users/{username}/Documents/Composer, and now we updated to /User/{username}, which i don't think it's the stardard, @cwhitten @tomlm .

From what i know, most application write to /Users/{username}/Documents/{appId} like VS, and Github desktop, IIS, and so on, for example
image

I thought this is the convention.

And there are a few application do write directly into /User/{username}, but they at least use a {appID} instead of create many folder's there, which is annoying and definitely not the standard
image

So i think we need to at least have an app identifier like composer, /User/{username}/{appID}, instead of directly writing to /User/{username}. I prefere /User/{username}/Documents/{appID} if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Painful if we don't fix, won't block releasing R9-RC Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants